Date: Wed, 4 Jul 2018 12:46:20 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Andrew Gallatin <gallatin@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335967 - head/sys/dev/mxge Message-ID: <201807041946.w64JkKHM044529@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201807041929.w64JT67O091471@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: gallatin > Date: Wed Jul 4 19:29:06 2018 > New Revision: 335967 > URL: https://svnweb.freebsd.org/changeset/base/335967 > > Log: > mxge: choose appropriate values for hw tso > > Modified: > head/sys/dev/mxge/if_mxge.c > > Modified: head/sys/dev/mxge/if_mxge.c > ============================================================================== > --- head/sys/dev/mxge/if_mxge.c Wed Jul 4 18:54:44 2018 (r335966) > +++ head/sys/dev/mxge/if_mxge.c Wed Jul 4 19:29:06 2018 (r335967) > @@ -4984,6 +4984,9 @@ mxge_attach(device_t dev) > ifp->if_ioctl = mxge_ioctl; > ifp->if_start = mxge_start; > ifp->if_get_counter = mxge_get_counter; > + ifp->if_hw_tsomax = 65536 - (ETHER_HDR_LEN + ETHER_VLAN_ENCAP_LEN); Would not this be more accurate (need to reorder assigns): ifp->if_hw_tsomax = ifp->if_hw_tsomaxsegsize - (ETHER_HDR_LEN + ETHER_VLAN_ENCAP_LEN); > + ifp->if_hw_tsomaxsegcount = sc->ss[0].tx.max_desc; > + ifp->if_hw_tsomaxsegsize = 65536; > /* Initialise the ifmedia structure */ > ifmedia_init(&sc->media, 0, mxge_media_change, > mxge_media_status); > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807041946.w64JkKHM044529>