Date: Sat, 30 Oct 2010 19:52:31 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Johan van Selst <johans@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/squid31 Makefile distinfo ports/www/squid31/files squid.in Message-ID: <4CCCD9EF.7010805@FreeBSD.org> In-Reply-To: <201010310036.o9V0aWIb042119@repoman.freebsd.org> References: <201010310036.o9V0aWIb042119@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
If -f ${squid_conf} is not optional (which from the script it would
appear that it is not) then it should be in command_args, not _flags
lest the user accidentally delete it. Of course you would then have to
add $command_args to the various places in the script where _flags is
currently present.
Please pass this along to the maintainer, since you didn't include their
e-mail address in the commit log ...
Doug
On 10/30/10 17:36, Johan van Selst wrote:
> johans 2010-10-31 00:36:32 UTC
>
> FreeBSD ports repository
>
> Modified files:
> www/squid31 Makefile distinfo
> www/squid31/files squid.in
> Log:
> - Update squid to 3.1.9
> - Replace two dead mirrors
> - Fix a bug in the squid rc script that caused the squid_conf
> rc.conf option to be non-functional
>
> PR: ports/151760 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=151760
> Submitted by: Thomas-Martin Seck (maintainer)
>
> Revision Changes Path
> 1.248 +3 -3 ports/www/squid31/Makefile
> 1.190 +3 -3 ports/www/squid31/distinfo
> 1.8 +2 -1 ports/www/squid31/files/squid.in
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/squid31/Makefile.diff?&r1=1.247&r2=1.248&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/squid31/distinfo.diff?&r1=1.189&r2=1.190&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/squid31/files/squid.in.diff?&r1=1.7&r2=1.8&f=h
>
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CCCD9EF.7010805>