Date: Wed, 14 Mar 2018 16:51:27 -0600 From: Alan Somers <asomers@freebsd.org> To: Shawn Webb <shawn.webb@hardenedbsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys Message-ID: <CAOtMX2g=aXd0gtHOoN2NiNv1ECG-mrZHR8KWrihzk6mEL14B%2Bg@mail.gmail.com> In-Reply-To: <20180314225009.gu3awgryggsxqmff@mutt-hbsd> References: <201802251429.w1PEThjY035303@repo.freebsd.org> <20180314225009.gu3awgryggsxqmff@mutt-hbsd>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 14, 2018 at 4:50 PM, Shawn Webb <shawn.webb@hardenedbsd.org> wrote: > On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > > Author: asomers > > Date: Sun Feb 25 14:29:43 2018 > > New Revision: 329984 > > URL: https://svnweb.freebsd.org/changeset/base/329984 > > > > Log: > > Don't declare __assfail as static > > > > It gets called by dmu_buf_init_user, which is inline but not static. > So it > > needs global linkage itself. > > > > Reported by: GCC-6 > > MFC after: 17 days > > X-MFC-With: 329722 > > > > Hey Alan, > > This commit breaks compiling world with ASAN. > > Some applications, like zfs, will fail with this error: > > /lib/libuutil.so.2: Undefined symbol "__assfail" > > Thanks, > How does one build world with ASAN ?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2g=aXd0gtHOoN2NiNv1ECG-mrZHR8KWrihzk6mEL14B%2Bg>