Date: Fri, 10 Sep 2021 12:23:25 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Kristof Provost <kp@freebsd.org>, donner@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2e5ff01d0a1f - main - if_vlan: add the ALTQ support to if_vlan. Message-ID: <YTuwrRd0KJZ9MtUe@FreeBSD.org> In-Reply-To: <202108250804.17P84SCM025164@gitrepo.freebsd.org> References: <202108250804.17P84SCM025164@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kristof,
On Wed, Aug 25, 2021 at 08:04:28AM +0000, Kristof Provost wrote:
K> commit 2e5ff01d0a1fabc757252f9c28ad5cddc98a652d
K> Author: Luiz Otavio O Souza <loos@FreeBSD.org>
K> AuthorDate: 2021-08-21 09:41:03 +0000
K> Commit: Kristof Provost <kp@FreeBSD.org>
K> CommitDate: 2021-08-25 06:56:45 +0000
K>
K> if_vlan: add the ALTQ support to if_vlan.
K>
K> Inspired by the iflib implementation, allow ALTQ to be used with if_vlan
K> interfaces.
K>
K> Reviewed by: donner
K> Obtained from: pfsense
K> MFC after: 1 week
K> Sponsored by: Rubicon Communications, LLC ("Netgate")
K> Differential Revision: https://reviews.freebsd.org/D31647
This was the last virtual interface standing without ALTQ. ng_iface(4),
tun(4) fell much earlier. I found it fundumentally wrong to add
queueing to a virtual interface. A virtual interface may classify
traffic, but actual queueing should happen only at the point of
physical bottlneck - the NIC.
Anyway, if somebody builds useful setups with such hack, let it live.
Same rationale was used when adding ALTQ to other virtual interfaces.
Just grumbling.
--
Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTuwrRd0KJZ9MtUe>