Date: Thu, 19 Jul 2001 19:06:58 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/nohup nohup.c nohup.1 Message-ID: <20010719190658.B56479@coffee.q9media.com> In-Reply-To: <xzp4rs8mtpe.fsf@flood.ping.uio.no>; from des@ofug.org on Fri, Jul 20, 2001 at 12:37:17AM %2B0200 References: <200107192125.f6JLPAE95986@freefall.freebsd.org> <xzp8zhkmv5o.fsf@flood.ping.uio.no> <20010719153226.B84709@dragon.nuxi.com> <xzp4rs8mtpe.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 20, 2001 at 12:37:17AM +0200, Dag-Erling Smorgrav wrote: > "David O'Brien" <obrien@FreeBSD.org> writes: > > On Fri, Jul 20, 2001 at 12:05:55AM +0200, Dag-Erling Smorgrav wrote: > > > Mike Barcroft <mike@FreeBSD.org> writes: > > > > Approved by: des > > > also reviewed by same. > > The assumption is if you approved something, you reviewed it. > > Not necessarily - I sometimes approve commits to code I maintain on > the basis of trust in the requesting committer's abilities. In this > particular case, however, Mike is my mentee, so I review every patch > he commits to pieces before I approve it. I made that assumption too, but I can see why you would also like to be listed on the 'Reviewed by' line. So in future I'll keep you on the 'Reviewed by' line. Problem solved. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010719190658.B56479>