Date: Mon, 02 Jun 2014 09:10:23 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Kohji Okuno <okuno.kohji@jp.panasonic.com>, freebsd-current@freebsd.org Subject: Re: About the type of physaddr in struct usb_page. Message-ID: <538C235F.9050105@selasky.org> In-Reply-To: <20140602.102221.1420138426517504976.okuno.kohji@jp.panasonic.com> References: <20140602.102221.1420138426517504976.okuno.kohji@jp.panasonic.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/02/14 03:22, Kohji Okuno wrote:
> Hi HPS,
>
> I think the type of physaddr in struct usb_page is incorrect.
> We shuld use bus_addr_t for physaddr.
> What do you think about this?
>
> 60 * The following structure defines physical and non kernel virtual
> 61 * address of a memory page having size USB_PAGE_SIZE.
> 62 */
> 63 struct usb_page {
> 64 #if USB_HAVE_BUSDMA
> 65 bus_size_t physaddr;
> 66 void *buffer; /* non Kernel Virtual Address */
> 67 #endif
> 68 };
>
> Regards,
> Kohji Okuno
Hi,
http://svnweb.freebsd.org/changeset/base/266969
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?538C235F.9050105>