Date: Sat, 18 Aug 2007 20:23:32 -0600 From: Scott Long <scottl@samsco.org> To: Daniel Eischen <deischen@FreeBSD.org> Cc: wine-freebsd@hub.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Robert Watson <rwatson@FreeBSD.org>, David Xu <davidxu@FreeBSD.org>, Tijl Coosemans <tijl@ulyssis.org>, Xin LI <delphij@delphij.net> Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys thr.h Message-ID: <46C7A9A4.5090404@samsco.org> In-Reply-To: <Pine.GSO.4.64.0708182050070.13363@sea.ntplx.net> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <Pine.GSO.4.64.0708162216530.1396@sea.ntplx.net> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <Pine.GSO.4.64.0708182050070.13363@sea.ntplx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Daniel Eischen wrote: > On Sat, 18 Aug 2007, Robert Watson wrote: > >> >> On Sat, 18 Aug 2007, Tijl Coosemans wrote: >> >>> Perhaps it should be stressed in documentation that this syscall is >>> only meant for Wine and to be removed at some point when better >>> solutions become available. I want to test this sigqueue solution >>> some more, because the indirection in signal delivery causes trouble >>> when a thread signals itself. I guess this would have to be >>> special-cased somehow then. >> >> As a general rule, removing system calls is discouraged as it breaks >> backward compatibility allowing newer kernels to run older >> applications, so I think we should avoid adding a system call with the >> intent to remove it in mind at the time it's added :-). While >> thr_kill2() is imperfect from several perspectives, it is certainly a >> minimalist and logical construction that can be easily understood, and >> that's pretty valuable. > > You can say that about a lot of APIs, but that doesn't mean we should add > them. This is a bit of a hack to satisfy one application (Wine) when there > are other (perhaps harder) ways to skin the cat. We certainly don't want > anything else using this API, so I'd advocate removing it. > I'm in strong agreement here. David? Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46C7A9A4.5090404>