Date: Thu, 17 May 2018 14:41:52 -0700 From: Matthew Macy <mmacy@freebsd.org> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333765 - head/sys/conf Message-ID: <CAPrugNp--n%2B%2BcctprGDBhVM8T_5o2RKw=6sWh2cJjXTyyUtGCw@mail.gmail.com> In-Reply-To: <148f3ab2-e62f-61e5-9c5f-68c97881a9ee@freebsd.org> References: <201805172104.w4HL4Kag068079@repo.freebsd.org> <148f3ab2-e62f-61e5-9c5f-68c97881a9ee@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
It's not breaking the build there, but I'd be fine with removing it more generally. -M On Thu, May 17, 2018 at 2:08 PM, Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: > > > On 05/17/18 14:04, Matt Macy wrote: >> >> Author: mmacy >> Date: Thu May 17 21:04:19 2018 >> New Revision: 333765 >> URL: https://svnweb.freebsd.org/changeset/base/333765 >> >> Log: >> powerpc: fix LINT build >> netmap currently doesn't build, take it out of LINT to prevent >> hiding regressions in universe >> Reviewed by: jhibbits >> Approved by: sbruno >> >> Modified: >> head/sys/conf/makeLINT.mk >> >> Modified: head/sys/conf/makeLINT.mk >> >> ============================================================================== >> --- head/sys/conf/makeLINT.mk Thu May 17 21:03:36 2018 (r333764) >> +++ head/sys/conf/makeLINT.mk Thu May 17 21:04:19 2018 (r333765) >> @@ -53,6 +53,7 @@ LINT: ${NOTES} ${MAKELINT_SED} >> .if ${TARGET} == "powerpc" >> # cat is available, not sure if cp is? >> cat ${.TARGET} > ${.TARGET}64 >> + echo "nodevice netmap" >> ${.TARGET} >> echo "machine ${TARGET} powerpc" >> ${.TARGET} >> echo "machine ${TARGET} powerpc64" >> ${.TARGET}64 >> .endif >> > > The build error is that it is broken on all 32-bit architectures because of > some integer/pointer type confusion, not just (32-bit) PowerPC. So, if we > aren't fixing it, it at least it should also be removed from ARM, i386, > mips, etc. > -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPrugNp--n%2B%2BcctprGDBhVM8T_5o2RKw=6sWh2cJjXTyyUtGCw>