Date: Fri, 7 Feb 2014 13:26:33 -0500 From: Eitan Adler <eadler@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r261604 - head/contrib/libc++/include Message-ID: <CAF6rxgnO%2BYD1eiUpouXyiYYN9cfRRXgDdF9%2Bmxa%2BD5BCAYSo0g@mail.gmail.com> In-Reply-To: <CAOtMX2hcxk0Ff5YBVBHc-qS5jwVseipwJig1GJCyYijwroFS0A@mail.gmail.com> References: <201402071810.s17IAZtx043815@svn.freebsd.org> <CAOtMX2hcxk0Ff5YBVBHc-qS5jwVseipwJig1GJCyYijwroFS0A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 7, 2014 at 1:14 PM, Alan Somers <asomers@freebsd.org> wrote: > On Fri, Feb 7, 2014 at 11:10 AM, Eitan Adler <eadler@freebsd.org> wrote: >> Author: eadler >> Date: Fri Feb 7 18:10:34 2014 >> New Revision: 261604 >> URL: http://svnweb.freebsd.org/changeset/base/261604 >> >> Log: >> HEAD is not buildable for the past day. Commit a 'quick fix' in order to permit >> buildworld to complete. >> >> Reviewed by: theraven >> >> Modified: >> head/contrib/libc++/include/locale > > Are you sure that this will work on all architectures? I didn't run 'make universe' but I think it should work. This was committed this after waiting a day for a real fix to be done. I had / have other work which I needed to get done and did not analize this code in detail. > It implicitly > assumes that ptrdiff_t is the same as long. It assumes that ptrdiff_t is signed and sizeof (ptrdiff_t) <= sizeof(long). Please feel free to modify my hack or otherwise fix the code. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnO%2BYD1eiUpouXyiYYN9cfRRXgDdF9%2Bmxa%2BD5BCAYSo0g>