Date: Tue, 16 Jun 2020 12:12:49 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Ian Lepore <ian@freebsd.org>, Toomas Soome <tsoome@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r362217 - head/stand/common Message-ID: <f54db645-6402-d77d-2271-d97fa1e2169f@FreeBSD.org> In-Reply-To: <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org> References: <202006160705.05G753T4057972@repo.freebsd.org> <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16/06/2020 12:01, Ian Lepore wrote: > On Tue, 2020-06-16 at 07:05 +0000, Toomas Soome wrote: >> Author: tsoome >> Date: Tue Jun 16 07:05:03 2020 >> New Revision: 362217 >> URL: https://svnweb.freebsd.org/changeset/base/362217 >> >> Log: >> loader: variable i is unused without MBR/GPT support built in >> >> Because i is only used as index in for loop, declare it in for >> statement. >> > As much as I prefer doing it this way, style(9) doesn't allow for > variable declarations inside a for() statement (or even inside a local > block, which is just too 1980s for me, but it is still our standard). Perhaps style(9) needs updating? I think KNF is mandatory for kernel code only, and is only suggested for userland. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f54db645-6402-d77d-2271-d97fa1e2169f>