Date: Fri, 27 Jul 2007 00:30:46 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Mike Tancsa <mike@sentex.net> Cc: Takeharu KATO <takeharu1219@ybb.ne.jp>, freebsd-current@freebsd.org Subject: Re: ichwd for ICH8 Message-ID: <86abtihk6h.fsf@ds4.des.no> In-Reply-To: <200707262035.l6QKZtnd067391@lava.sentex.ca> (Mike Tancsa's message of "Thu\, 26 Jul 2007 16\:35\:51 -0400") References: <46337B06.9080102@ybb.ne.jp> <46338C0F.9000608@ybb.ne.jp> <4633932A.8080602@ybb.ne.jp> <86tzuxni1b.fsf@dwp.des.no> <200707061723.l66HNYSe037055@lava.sentex.ca> <86ir86hqhc.fsf@ds4.des.no> <200707262035.l6QKZtnd067391@lava.sentex.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
Mike Tancsa <mike@sentex.net> writes:
> Thanks! On RELENG_6,
The patch is for CURRENT.
> /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c: In function ichwd_cle=
ar_noreboot':
> /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c:228: warning: implicit=
declaration of function `device__printf'
> /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c:228: warning: nested e=
xtern declaration of `device__printf'
> *** Error code 1
Typo...
> ichwd module loaded
> ichwd0: <Intel ICH7 watchdog timer> on isa0
> ichwd0: unable to reserve GCS registers
> device_attach: ichwd0 attach returned 6
in ichwd_identify(), the ICH version test is wrong, it should be
- if (id_p->version =3D=3D 2) {
+ if (id_p->version >=3D 6) {
> Same error on current
>
> ichwd module loaded
> ichwd0: <Intel ICH7 watchdog timer> on isa0
> ichwd0: ICH WDT present but disabled in BIOS or hardware
> device_attach: ichwd0 attach returned 6
Not the same error, but probably caused by the same mistake in
ichwd_identify()
DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86abtihk6h.fsf>