Date: Thu, 23 Nov 2017 04:41:38 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: Shawn Webb <shawn.webb@hardenedbsd.org> Cc: Mateusz Guzik <mjg@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326107 - in head/sys: kern sys Message-ID: <CAGudoHGSQP-8Zb76qn0z_OGta4_uFfZnZQvewJr2FbwaJotE7Q@mail.gmail.com> In-Reply-To: <20171123031720.4iyoyvfyhxsltexw@mutt-hbsd> References: <201711222204.vAMM44FW023951@repo.freebsd.org> <20171123031720.4iyoyvfyhxsltexw@mutt-hbsd>
next in thread | previous in thread | raw e-mail | index | archive | help
oops, fixed in r326107 On Thu, Nov 23, 2017 at 4:17 AM, Shawn Webb <shawn.webb@hardenedbsd.org> wrote: > On Wed, Nov 22, 2017 at 10:04:04PM +0000, Mateusz Guzik wrote: > > Author: mjg > > Date: Wed Nov 22 22:04:04 2017 > > New Revision: 326107 > > URL: https://svnweb.freebsd.org/changeset/base/326107 > > > > Log: > > locks: pass the found lock value to unlock slow path > > > > This avoids an explicit read later. > > > > While here whack the cheaply obtainable 'tid' argument. > > > > Modified: > > head/sys/kern/kern_mutex.c > > head/sys/kern/kern_rwlock.c > > head/sys/kern/kern_sx.c > > head/sys/sys/mutex.h > > head/sys/sys/rwlock.h > > head/sys/sys/sx.h > > This breaks ZFS: > https://gist.github.com/lattera/93faa9c47ccc985ebda039ab31641c2c > > Thanks, > > -- > Shawn Webb > Cofounder and Security Engineer > HardenedBSD > > GPG Key ID: 0x6A84658F52456EEE > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE > -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHGSQP-8Zb76qn0z_OGta4_uFfZnZQvewJr2FbwaJotE7Q>