Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Jan 1999 22:40:16 -0700
From:      Nate Williams <nate@mt.sri.com>
To:        Archie Cobbs <archie@whistle.com>
Cc:        wollman@khavrinen.lcs.mit.edu (Garrett Wollman), current@FreeBSD.ORG
Subject:   Re: btokup() macro in sys/malloc.h
Message-ID:  <199901280540.WAA26288@mt.sri.com>
In-Reply-To: <199901280229.SAA20207@bubba.whistle.com>
References:  <199901280222.VAA14212@khavrinen.lcs.mit.edu> <199901280229.SAA20207@bubba.whistle.com>

next in thread | previous in thread | raw e-mail | index | archive | help
> Anyway, if we're going to -Wall'ify the kernel (as we should)
> then we need to update sytle(9) to reflect that.
> 
> In fact, style(9) should say:
> 
>   If at all possible, your code should compile without warnings
>   when the gcc -Wall flag is given.

I disagree.  As has been shown many times in the past (and I suspect the
down-under constituent will show that at least a couple of the
'warnings' fixes will be wrong and hide bogus code), making -Wall a goal
causes people to cover up bad code with bad casts and such.

'-Wall' is *NOT* a good design goal.



Nate

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901280540.WAA26288>