Date: Wed, 05 Sep 2012 00:11:14 -0500 From: Mike Silbersack <silby@silby.com> To: pyunyh@gmail.com Cc: freebsd-net@freebsd.org, davidch@freebsd.org, yongari@freebsd.org Subject: Re: [patch] if_bxe shutdown fix Message-ID: <5046DEF2.9040901@silby.com> In-Reply-To: <20120905205654.GA1449@michelle.cdnetworks.com> References: <5046D681.2040806@silby.com> <20120905205654.GA1449@michelle.cdnetworks.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/5/12 3:56 PM, YongHyeon PYUN wrote: > On Tue, Sep 04, 2012 at 11:35:13PM -0500, Mike Silbersack wrote: >> Does anyone want to review this patch before I check it in? The change >> has been reviewed and tested by coworkers, but not yet reviewed by any >> other FreeBSD committers. >> >> http://www.silby.com/patches/if_bxe.c-safestop.patch >> >> This resolves an issue we saw at work where IPMI would report bus errors >> when you rebooted a system with bxe NICs if you had not UP'd all of the >> bxe NICs before the shutdown. > Yeah I also have a similar patch. But I checked sc->state after > getting a BXE_CORE_LOCK as the state is protected by the lock. > >> Thanks, >> >> Mike "Silby" Silbersack Good catch. How does this look? http://www.silby.com/patches/if_bxe.c-safestop-2.patch Mike "Silby" Silbersack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5046DEF2.9040901>