Date: Thu, 7 Nov 2013 12:34:37 -0800 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Ian Lepore <ian@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Steve Kargl <kargl@FreeBSD.org> Subject: Re: svn commit: r257770 - head/lib/msun/src Message-ID: <20131107203437.GA60686@troutmask.apl.washington.edu> In-Reply-To: <1383856221.31172.226.camel@revolution.hippie.lan> References: <201311062344.rA6Niqkf001246@svn.freebsd.org> <1383854281.31172.214.camel@revolution.hippie.lan> <20131107201946.GA58797@troutmask.apl.washington.edu> <1383856221.31172.226.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 07, 2013 at 01:30:21PM -0700, Ian Lepore wrote:
> >
> > I zero about floating-point on arm. Does long double have
I know ...
> > 64, 80, or 113-bit significands?
> >
>
> I don't know either (for some reason I'm thinking long double is synonym
> for double on arm, but I can't remember why I think that).
>
> This compile failure isn't just arm, btw, it's also powerpc and mips.
> sparc and x86 seem to be okay.
>
Inspection of the various _fpmath.h files shows that failures
are on long double == double platforms. Can you test this
patch?
Index: Makefile
===================================================================
--- Makefile (revision 257810)
+++ Makefile (working copy)
@@ -71,7 +71,7 @@
s_lround.c s_lroundf.c s_lroundl.c s_modff.c \
s_nan.c s_nearbyint.c s_nextafter.c s_nextafterf.c \
s_nexttowardf.c s_remquo.c s_remquof.c \
- s_rint.c s_rintf.c s_round.c s_roundf.c s_roundl.c \
+ s_rint.c s_rintf.c s_round.c s_roundf.c \
s_scalbln.c s_scalbn.c s_scalbnf.c s_signbit.c \
s_signgam.c s_significand.c s_significandf.c s_sin.c s_sinf.c \
s_tan.c s_tanf.c s_tanh.c s_tanhf.c s_tgammaf.c s_trunc.c s_truncf.c \
@@ -101,7 +101,7 @@
s_asinhl.c s_atanl.c s_cbrtl.c s_ceill.c s_cosl.c s_cprojl.c \
s_csqrtl.c s_exp2l.c s_expl.c s_floorl.c s_fmal.c \
s_frexpl.c s_logbl.c s_logl.c s_nanl.c s_nextafterl.c \
- s_nexttoward.c s_remquol.c s_rintl.c s_scalbnl.c \
+ s_nexttoward.c s_remquol.c s_rintl.c s_roundl.c s_scalbnl.c \
s_sinl.c s_tanl.c s_truncl.c w_cabsl.c
.endif
Index: src/s_round.c
===================================================================
--- src/s_round.c (revision 257810)
+++ src/s_round.c (working copy)
@@ -52,3 +52,7 @@
return (-t);
}
}
+
+#if (LDBL_MANT_DIG == 53)
+__weak_reference(round, roundl);
+#endif
--
Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131107203437.GA60686>