Date: Fri, 18 Feb 2011 20:28:03 -0500 From: Michael Butler <imb@protected-networks.net> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: rename on socket fails :-( Message-ID: <4D5F1CA3.3040408@protected-networks.net> In-Reply-To: <20110218232218.GC78089@deviant.kiev.zoral.com.ua> References: <20110218215330.GA9549@mail.auburn.protected-networks.net> <20110218221108.GB78089@deviant.kiev.zoral.com.ua> <20110218223358.GB9549@mail.auburn.protected-networks.net> <20110218232218.GC78089@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/18/11 18:22, Kostik Belousov wrote:
>
> The patch below fixed the bug for the test extracted from your kdump.
>
> diff --git a/sys/ufs/ufs/ufs_vnops.c b/sys/ufs/ufs/ufs_vnops.c
> index 084971e..34b1758 100644
> --- a/sys/ufs/ufs/ufs_vnops.c
> +++ b/sys/ufs/ufs/ufs_vnops.c
> @@ -1295,7 +1295,9 @@ relock:
> newparent = tdp->i_number;
> doingdirectory = 1;
> }
> - if (fvp->v_mountedhere != NULL || (tvp && tvp->v_mountedhere != NULL)) {
> + if ((fvp->v_type == VDIR && fvp->v_mountedhere != NULL) ||
> + (tvp != NULL && tvp->v_type == VDIR &&
> + tvp->v_mountedhere != NULL)) {
> error = EXDEV;
> goto unlockout;
> }
To confirm - this fixes the issue - thanks!
imb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iEYEARECAAYFAk1fHKMACgkQQv9rrgRC1JKt+ACgv6Cx9NVZapjDn0bMUskLs7jM
ym8An0YIQKWY0dcJ12qX9zV4c6ePzgD+
=JQxR
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D5F1CA3.3040408>