Date: Thu, 29 Mar 2018 23:22:16 +0300 From: Konstantin Belousov <kib@freebsd.org> To: Slawa Olhovchenkov <slw@zxy.spb.ru> Cc: Kevin Oberman <rkoberman@gmail.com>, Gary Palmer <gpalmer@freebsd.org>, Eric van Gyzen <eric@vangyzen.net>, FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org> Subject: Re: KBI unexpexted change in stable/11 ? Message-ID: <20180329202216.GH1774@kib.kiev.ua> In-Reply-To: <20180329182143.GE6612@zxy.spb.ru> References: <20180328130903.GC6612@zxy.spb.ru> <316fb5cd-720b-e62a-cb56-5e9b722d05e9@vangyzen.net> <20180328153529.GL4305@zxy.spb.ru> <0b3b3294-7de4-cb1c-f85b-b846b46e8d75@vangyzen.net> <20180328164646.GC59700@in-addr.com> <CAN6yY1scXvg=nYKd_n7XqLcg02xP2yNU615T2SFzY4xQPR4rXg@mail.gmail.com> <20180329182143.GE6612@zxy.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 29, 2018 at 09:21:43PM +0300, Slawa Olhovchenkov wrote: > On Wed, Mar 28, 2018 at 11:25:08PM -0700, Kevin Oberman wrote: > > > > > > r325665 is previos point and is good. > > > > > r331615 crashed. > > > > > Can I use some script for bisect? > > > > > > > > I'm not aware of a script for this. The only tool I've used is "git > > > > bisect", which is very handy if you're already familiar with git. > > > > > > You may want to try devel/p5-App-SVN-Bisect. Never used it, so > > > no idea if it's functional or helpful, just found it doing a quick > > > search > > > > It would be nice if this could be fixed, but it is the case. > > r328475 bad (tzdata) > r328469 in progress (kib, sys/vm) > r328463 in progress (don't touch kernel) > r328462 good > > I mean r328469 break KBI. This commit is basically required to avoid significant confusion between HEAD and stable code. Its absense might make other merges impossible or quite hard. In fact, my opinion is that the real bug is elsewere. We do provide vm_map_min/max KPI, but the KPI is not KBI-stable because it encodes struct vm_map layout into binaries which (correctly) use KPI instead of directly accessing struct vm_map. This should be fixed, I put the review https://reviews.freebsd.org/D14902 for it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180329202216.GH1774>