Date: Wed, 14 Aug 2013 04:25:57 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: gjb@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r254224 - head/share/man/man7 Message-ID: <20130814.042557.877689080765344354.hrs@allbsd.org> In-Reply-To: <201308111857.r7BIvRSq080970@svn.freebsd.org> References: <201308111857.r7BIvRSq080970@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Glen Barber <gjb@FreeBSD.org> wrote
in <201308111857.r7BIvRSq080970@svn.freebsd.org>:
gj> +.It Va SVNROOT
gj> +The
gj> +.Xr svn 1
gj> +host used to check out the various trees.
gj> Defaults to
gj> -.Pa svn://svn.freebsd.org .
gj> -.It Ev SVNROOTSRC
gj> -The URL of the FreeBSD SVN source repository.
gj> +.Pa svn://svn.FreeeBSD.org .
gj> +.It Va SRCBRANCH
gj> +The
gj> +.Li src/
gj> +branch to use.
gj> Defaults to
gj> -.Pa ${SVNROOTBASE}/base .
gj> -.It Ev SVNROOTDOC
gj> -The URL of the FreeBSD SVN doc repository.
gj> +.Va head/ .
gj> +.It Va DOCBRANCH
gj> +The
gj> +.Li doc/
gj> +branch to use.
gj> Defaults to
gj> -.Pa ${SVNROOTBASE}/doc .
gj> -.It Ev SVNROOTPORTS
gj> -The URL of the FreeBSD SVN ports repository.
gj> +.Va head/ .
gj> +.It Va PORTBRANCH
gj> +The
gj> +.Li ports/
gj> +branch to use.
gj> Defaults to
gj> -.Pa ${SVNROOTBASE}/ports .
gj> -.It Ev BRANCHDOC
gj> -The branch name of the FreeBSD SVN doc repository.
gj> +.Va head/ .
gj> +.It Va SRCREVISION
gj> +The revision of the
gj> +.Li src/
gj> +tree to use.
gj> +Defaults to the current top of tree revision.
gj> +.It Va DOCREVISION
gj> +The revision of the
gj> +.Li doc/
gj> +tree to use.
gj> +Defaults to the current top of tree revision.
gj> +.It Va PORTREVISION
Why separation between revision and branch is needed? I
intentionally dropped this part from your old patch to
generate-release.sh because branch and revision number can be
specified like releng/9.2@NNN in a single variable. An incorrect
configuration of the two variables do not always cause a fatal error,
so specification in fewer number of variables is more foolproof.
gj> +.It Va TARGET
gj> +The target machine type for the release.
gj> +Defaults to the current machine type.
gj> +.It Va TARGET_ARCH
gj> +The target machine architecture for the release.
gj> +Defaults to the value of
gj> +.Va TARGET .
gj> +.Pp
Please remove default configuration of these variables from
release.sh. The reasonable defaults are already set in src/Makefile
and setting TARGET_ARCH=$TARGET by default is simply wrong. Also,
get_rev_branch() is redundant.
gj> +Defaults to setting the number of
gj> +.Xr make 1
gj> +jobs
gj> +.Pq Ar -j
gj> +to half the number of CPUs available on the system.
Did you try this on a uniprocessor machine?
-- Hiroki
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (FreeBSD)
iEYEABECAAYFAlIKiEYACgkQTyzT2CeTzy1jZwCgoWVFE2/vrFBSTDCdcsnTDWgu
97sAn3ka5P4LaQsvp7706Z5k4yUIpLBh
=4PJo
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130814.042557.877689080765344354.hrs>