Date: Wed, 06 Jun 2007 09:25:38 +0800 From: LI Xin <delphij@delphij.net> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-src@FreeBSD.ORG, ceri@submonkey.net, delphij@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/sysinstall installUpgrade.c Message-ID: <46660D12.4050600@delphij.net> In-Reply-To: <20070605.161442.1723940823.imp@bsdimp.com> References: <200706050544.l555ifKp014690@repoman.freebsd.org> <20070605190601.GC1834@submonkey.net> <20070605.161442.1723940823.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8A13177FB9A260F6DA651FB0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi, What about: %%% vsystem("disklabel -B `awk $2~/\\/$/ {print substr($1, 6, length($1)-6)} /etc/fstab`); %%% Well, I admit that replacing a piece of non-working code with a workaround is not generally a good idea, but I did not found a perfect solution yet, and it does not make us any good to leave an installer bug as is if the old code does not work at all :-) This is still not perfect (does not work on a root slice, for instance), but it would cover more cases and does not need yet another generator. Cheers, --=20 Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! --------------enig8A13177FB9A260F6DA651FB0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGZg0SOfuToMruuMARCvSRAKCAXBe7BtnRcCoTxPr2BYPEgTp1DQCgieJn 97DA5Qddmijo4anCP8RwG7g= =ItVo -----END PGP SIGNATURE----- --------------enig8A13177FB9A260F6DA651FB0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46660D12.4050600>