Date: Fri, 15 Feb 2019 22:42:27 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344191 - head/sbin/nvmecontrol Message-ID: <A4E5D80E-4F6A-4E34-AA7C-A2598EEA3AE8@gmail.com> In-Reply-To: <CANCZdfqyHws0YDzqpALoCMUZ2sT-m9KzA1yFM9iR9zYTSeE5=Q@mail.gmail.com> References: <201902160015.x1G0F3EJ060777@repo.freebsd.org> <EBC9A98F-5E80-458F-927E-38948C0BC913@gmail.com> <CANCZdfqyHws0YDzqpALoCMUZ2sT-m9KzA1yFM9iR9zYTSeE5=Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 15, 2019, at 10:25 PM, Warner Losh <imp@bsdimp.com> wrote: > > On Fri, Feb 15, 2019, 9:55 PM Enji Cooper <yaneurabeya@gmail.com <mailto:yaneurabeya@gmail.com> wrote: > > > On Feb 15, 2019, at 16:15, Warner Losh <imp@freebsd.org <mailto:imp@freebsd.org>> wrote: > > > > Author: imp > > Date: Sat Feb 16 00:15:02 2019 > > New Revision: 344191 > > URL: https://svnweb.freebsd.org/changeset/base/344191 <https://svnweb.freebsd.org/changeset/base/344191>; > > > > Log: > > Remove write-only s_flag. > > > > Modified: > > head/sbin/nvmecontrol/firmware.c > > > > Modified: head/sbin/nvmecontrol/firmware.c > > ============================================================================== > > --- head/sbin/nvmecontrol/firmware.c Fri Feb 15 23:46:34 2019 (r344190) > > +++ head/sbin/nvmecontrol/firmware.c Sat Feb 16 00:15:02 2019 (r344191) > > @@ -177,7 +177,7 @@ static void > > firmware(const struct nvme_function *nf, int argc, char *argv[]) > > { > > int fd = -1, slot = 0; > > - int a_flag, s_flag, f_flag; > > + int a_flag, f_flag; > > int activate_action, reboot_required; > > int opt; > > char *p, *image = NULL; > > @@ -188,7 +188,7 @@ firmware(const struct nvme_function *nf, int argc, cha > > uint8_t fw_slot1_ro, fw_num_slots; > > struct nvme_controller_data cdata; > > > > - a_flag = s_flag = f_flag = false; > > + a_flag = f_flag = false; > > > > while ((opt = getopt(argc, argv, "af:s:")) != -1) { > > Hi Warner! > Should “s:” be removed here, along with any corresponding documentation about ‘-s foo’? > > The docs are poo. s: should not be removed, since it is the slot and required. The code set slot and s_flag. The latter is bogus, so I removed it. 0-o.. I see. Ok, carry on! -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A4E5D80E-4F6A-4E34-AA7C-A2598EEA3AE8>