Date: Mon, 11 Aug 2008 17:33:22 +0100 From: Dieter <freebsd@sopwith.solgatos.com> To: Sean Bruno <sbruno@miralink.com> Cc: Scott Long <scottl@freebsd.org>, freebsd-firewire@freebsd.org Subject: Re: This is where I'm going with fwcontrol Message-ID: <200808120033.AAA07139@sopwith.solgatos.com> In-Reply-To: Your message of "Sat, 09 Aug 2008 13:12:28 PDT." <489DFA2C.4080407@miralink.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> Also, I changed some of the variable to check for >= 0 and set their > default values to -1. This should have the same effect as adding a new > variable as you did in your fix. If you're going to do it that way, the code should check that the argument is in range, and print a complaint if out of range. Otherwise the user could say "fwcontrol -f -1" and nothing would happen. And the man page should list the legal range. Hmmm, actually these should be done even with the add-a-new-variable method.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808120033.AAA07139>