Date: Thu, 5 Jun 2025 19:14:19 -0600 From: Warner Losh <imp@bsdimp.com> To: Charlie Li <vishwin@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 60159a98a837 - main - nvme: Move opcode and status code tables from base CAM to nvme_util.c Message-ID: <CANCZdfoyYathT2Q=TmVjr7ETvB9-hN1hVXgKgaUY5xxsrpDQLw@mail.gmail.com> In-Reply-To: <371a7bf2-61ee-4528-9aec-846601973b78@freebsd.org> References: <202506052106.555L6XBV089396@gitrepo.freebsd.org> <53d9ce10-191c-4edf-85d1-41b3162aefa4@freebsd.org> <d2f95ea5-aa29-4e7a-804c-4980d1a29f9e@FreeBSD.org> <371a7bf2-61ee-4528-9aec-846601973b78@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Jun 5, 2025, 6:46 PM Charlie Li <vishwin@freebsd.org> wrote: > John Baldwin wrote: > > On 6/5/25 19:29, Charlie Li wrote: > >> <sys/dev/nvme.h> doesn't appear to be making it in nvme_all.h as the > >> build complains about missing nvme_opcode_sbuf() in nvme_all.c. > > > > Are you getting a link error or a compile error? I built this locally > > several times > > today to test various combinations (kernels with and without either CAM > > or nvme and > > loading nvme.ko in kernels without to make sure it worked). I also > > built GENERIC > > prior to pushing and it built fine. > > > Compile error in buildworld. > In libcam? Warner > Sigh, so from ci.freebsd.org, it appears to be userland that is choking > > (libcam) > > rather than the kernel. I'll fix shortly (mostly it just means removing > > the > > #ifdef _KERNEL). > > > > -- > Charlie Li > ...nope, still don't have an exit line. > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Thu, Jun 5, 2025, 6:46 PM Charlie Li <<a href="mailto:vishwin@freebsd.org">vishwin@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">John Baldwin wrote:<br> > On 6/5/25 19:29, Charlie Li wrote:<br> >> <sys/dev/nvme.h> doesn't appear to be making it in nvme_all.h as the<br> >> build complains about missing nvme_opcode_sbuf() in nvme_all.c.<br> > <br> > Are you getting a link error or a compile error? I built this locally <br> > several times<br> > today to test various combinations (kernels with and without either CAM <br> > or nvme and<br> > loading nvme.ko in kernels without to make sure it worked). I also <br> > built GENERIC<br> > prior to pushing and it built fine.<br> > <br> Compile error in buildworld.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">In libcam?</div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> > Sigh, so from <a href="http://ci.freebsd.org" rel="noreferrer noreferrer" target="_blank">ci.freebsd.org</a>, it appears to be userland that is choking <br> > (libcam)<br> > rather than the kernel. I'll fix shortly (mostly it just means removing <br> > the<br> > #ifdef _KERNEL).<br> > <br> <br> -- <br> Charlie Li<br> ...nope, still don't have an exit line.<br> </blockquote></div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoyYathT2Q=TmVjr7ETvB9-hN1hVXgKgaUY5xxsrpDQLw>