Date: Thu, 3 Oct 2002 19:14:51 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Juli Mallett <jmallett@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/kern kern_synch.c Message-ID: <20021003190351.U3114-100000@gamplex.bde.org> In-Reply-To: <200210030409.g93490uo016016@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2 Oct 2002, Juli Mallett wrote: > jmallett 2002/10/02 21:09:00 PDT > > Modified files: > sys/kern kern_synch.c > Log: > XXX Add a check for p->p_limit being NULL before dereferencing it. This is > totally bogus but will hide the occurances of access of 0xbc(NULL) which > people have run into lately. This is not a proper fix, just a bandaid, until > the cause of this happening is tracked down and fixed. > > Reviewed by: rwatson > > Revision Changes Path > 1.201 +6 -1 src/sys/kern/kern_synch.c The PRS_ZOMBIE check was supposed to prevent the pointer being NULL. I think this check is bogus too, and have removed it. The corresponding SZOMB check is not present in Lite2. It doesn't make sense for zombies to switch context. BTW, the Lite2 version of mi_switch() is depressingly cleaner than the current version, but not as clean as the FreeBSD-1 version which is so clean that it didn't exist. (The MI parts of switch() in Lite2 were just timestamp stuff including enforcing the rlimit, and bumping the counter. FreeBSD-1 didn't even have the timestamp stuff, so there was one MI thing for switch() to do (just bumping the counter), and that was so simple that it was done in MD code.). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021003190351.U3114-100000>