Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 8 Jan 2017 12:49:38 -0800
From:      Mark Johnston <markj@FreeBSD.org>
To:        George Neville-Neil <gnn@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r311225 - head/sys/netinet
Message-ID:  <20170108204938.GC34440@raichu>
In-Reply-To: <AC05F949-03EA-4A2C-8AF6-3C77A9A057D8@freebsd.org>
References:  <201701040219.v042JDEk026544@repo.freebsd.org> <20170104182630.GA26522@wkstn-mjohnston.west.isilon.com> <4C01D080-64D9-4862-AFD5-42CC49B5CC0B@freebsd.org> <AC05F949-03EA-4A2C-8AF6-3C77A9A057D8@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 07, 2017 at 02:31:28PM -0500, George Neville-Neil wrote:
> 
> 
> On 7 Jan 2017, at 14:23, George Neville-Neil wrote:
> 
> > On 4 Jan 2017, at 13:26, Mark Johnston wrote:
> >
> >> On Wed, Jan 04, 2017 at 02:19:13AM +0000, George V. Neville-Neil 
> >> wrote:
> >>> Author: gnn
> >>> Date: Wed Jan  4 02:19:13 2017
> >>> New Revision: 311225
> >>> URL: https://svnweb.freebsd.org/changeset/base/311225
> >>>
> >>> Log:
> >>>   Fix DTrace TCP tracepoints to not use mtod() as it is both 
> >>> unnecessary and
> >>>   dangerous.  Those wanting data from an mbuf should use DTrace 
> >>> itself to get
> >>>   the data.
> >>
> >> I think you also need to update the types in in_kdtrace.c, and add a
> >> translator for struct mbuf * to ipinfo_t.
> >
> > Fair points.
> >
> 
> Actually, following up to myself, this does not need to be done just 
> yet.  The pkt_info stuff is currently always NULL.  I'm working on a 
> copyoutmbuf() subroutine that will make all of this much cleaner.

The pkt_info stuff is unrelated to this - ipinfo_t is the third
argument to the tcp probes. The translator which expects a pointer to
the IP header is now getting a pointer to an mbuf, so this change
effectively breaks scripts that use args[2] in a tcp:::send or
tcp:::receive probe (among others).



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170108204938.GC34440>