Date: Thu, 26 Jul 2007 21:12:01 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c Message-ID: <20070726191201.GR12473@garage.freebsd.pl> In-Reply-To: <200707261418.59436.jhb@freebsd.org> References: <200707261658.l6QGwAs8038591@repoman.freebsd.org> <200707261418.59436.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, Jul 26, 2007 at 02:18:58PM -0400, John Baldwin wrote: > On Thursday 26 July 2007 12:58:10 pm Pawel Jakub Dawidek wrote: > > pjd 2007-07-26 16:58:09 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/fs/devfs devfs_vnops.c > > sys/fs/fifofs fifo_vnops.c > > sys/kern uipc_usrreq.c vfs_vnops.c > > sys/vm vnode_pager.c > > Log: > > When we do open, we should lock the vnode exclusively. This fixes few > races: > > - fifo race, where two threads assign v_fifoinfo, > > - v_writecount modifications, > > - v_object modifications, > > - and probably more... > > Is it possible this could fix some 'vrele: negative ref cnt' and 'vput: > negative ref cnt' panics I am seeing on 6.x? I see similar panic on NFS root vnode, but this change won't fix it. v_usecount is protected by vnode's internal lock, not vnode lock. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGqPIBForvXbEpPzQRAvZgAJ965qgQTKO/Y/RsxM3Z6zsw0TceoQCePs6D 1VIj4WItNSzNEkiPbMi3RbY= =3QUl -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070726191201.GR12473>