Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 11 Feb 2009 12:05:17 +0100
From:      =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To:        Kirk McKusick <mckusick@FreeBSD.org>
Cc:        svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r188434 - projects/quota64/lib/libutil
Message-ID:  <86iqnhnsia.fsf@ds4.des.no>
In-Reply-To: <200902100811.n1A8Bigw085658@svn.freebsd.org> (Kirk McKusick's message of "Tue, 10 Feb 2009 08:11:44 %2B0000 (UTC)")
References:  <200902100811.n1A8Bigw085658@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail 

Kirk McKusick <mckusick@FreeBSD.org> writes:
> @@ -231,7 +231,7 @@ quota_write32(struct quotafile *qf, cons
>  	off = id * sizeof(struct dqblk32);
>  	if (lseek(qf->fd, off, SEEK_SET) == -1)
>  		return (-1);
> -	return (write(qf->fd, &dqb32, sizeof(dqb32)));
> +	return (write(qf->fd, &dqb32, sizeof(dqb32)) == -1);
>  }
>  
>  static int

I would prefer -1 for failure and 0 for success...

DES
-- 
Dag-Erling Smørgrav - des@des.no
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86iqnhnsia.fsf>