Date: Wed, 18 Dec 2019 17:53:41 +0100 From: Yamagi <lists@yamagi.org> To: vmaffione@FreeBSD.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355301 - head/usr.sbin/bhyve Message-ID: <20191218175341.214724de595423ecfe528dff@yamagi.org> In-Reply-To: <201912022051.xB2Kplot078056@repo.freebsd.org> References: <201912022051.xB2Kplot078056@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Wed__18_Dec_2019_17_53_41_+0100_DAj1qso_aVhziwSm
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hello,
the change to the defintion of 'const char *vbuf' in rfb.c is wrong.
The protocol version string must be send as "RFB 003.008\n" and not as
"RFB 003.008\n\r", otherwise the VNC client isn't able to complete the
handshake (it doesn't recognize the protocol version). While it stays
connected, it doesn't show anything.
This patch fixes it for me:
diff --git a/usr.sbin/bhyve/rfb.c b/usr.sbin/bhyve/rfb.c
index b8fe6e3137d..9c8c6eb0764 100644
--- a/usr.sbin/bhyve/rfb.c
+++ b/usr.sbin/bhyve/rfb.c
@@ -744,7 +744,7 @@ rfb_wr_thr(void *arg)
void
rfb_handle(struct rfb_softc *rc, int cfd)
{
- const char *vbuf =3D "RFB 003.008\n\r";
+ const char *vbuf =3D "RFB 003.008\n";
unsigned char buf[80];
unsigned char *message =3D NULL;
Regards,
Yamagi
On Mon, 2 Dec 2019 20:51:47 +0000 (UTC)
Vincenzo Maffione <vmaffione@FreeBSD.org> wrote:
> Author: vmaffione
> Date: Mon Dec 2 20:51:46 2019
> New Revision: 355301
> URL: https://svnweb.freebsd.org/changeset/base/355301
>=20
> Log:
> bhyve: uniform printf format string newlines
> =20
> Some of the printf statements only use LF to get a newline. However, a =
CR character is also required for the serial console to print debug logs in=
a nice way.
> Fix those code locations that only use LF, by adding a CR character.
> =20
> Reviewed by: markj, aleksandr.fedorov@itglobal.com
> MFC after: 1 week
> Differential Revision: https://reviews.freebsd.org/D22552
--Signature=_Wed__18_Dec_2019_17_53_41_+0100_DAj1qso_aVhziwSm
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEOXu/lxyufwz0gC5x6xRy5x1QJRUFAl36WZUACgkQ6xRy5x1Q
JRW4mQ/+MKlZap5WgUc4GhNf/DGfXLkOTRcf+/DjQhLjSTjW4lu9QLA70yuQMkTu
QaLqrMWX5L6xdYLWuBNtrAglaC5ECJJHnEcXB17JpQgUn/cLFmjqDYdaznjc/X7S
7GvTPu7rgWk1kz7sASGEjsW+4UgU0iFVPBZYUVJvc5YJKvNfAf3EcV5vIjEXjouS
GM5juH1llHl3dAQU4eHwI8DRieJGvp37irLz/JKJrb/i5rtMoGVB74SM4jfOk/7d
zf6F2yketl0Ct5spq2vhr46URzaUeOBnTMIdnUPQycJjSbw8Oq+j9VTOyeN7YKJ8
UJHBYhg+HzrF7J0Jc/45fi3Y6yNh7KYvPxeu051ZKKHwg5ZabbpRjVUvfpcrEXTM
z4F0lhOBsII/HA/9G5kiJMCrk4Im/2K1vg6vNGdNSYzengBZi4/wlqUwKLe5luMY
6PAjTZCKr2/3z4CHcZJLlfh3hv7UvPVZ2a6wI2VBD+GHOgJdIpzK9HZYvXFs5N0+
KS/ThrB2dDK+3KpbbOffk5FFmvpVEMtMkyzzC+OQVl1EZ6hqhcFxrHeolYrUp4oU
GhC+oKFRx8Iic/XUIkiPh43mTGOEmFG83RsQ94L5ZxIgRkbYdASwtsczB7NHO3yn
n5X3HM5TYy+pE9QbY8qyuu1pcSTvXCtW8dejBOe5YcJCtnaPKBE=
=X39R
-----END PGP SIGNATURE-----
--Signature=_Wed__18_Dec_2019_17_53_41_+0100_DAj1qso_aVhziwSm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191218175341.214724de595423ecfe528dff>