Date: Mon, 23 Mar 1998 06:16:37 -0500 From: Randall Hopper <rhh@ct.picker.com> To: Amancio Hasty <hasty@rah.star-gate.com>, Mark Murray <mark@grondar.za>, asami@FreeBSD.ORG Cc: Joao Carlos Mendes Luis <jonny@coppe.ufrj.br>, multimedia@FreeBSD.ORG, stable@FreeBSD.ORG, committers@FreeBSD.ORG Subject: Re: Fxtv vs Stable Message-ID: <19980323061637.00745@ct.picker.com> In-Reply-To: <199803230612.IAA03716@greenpeace.grondar.za>; from Mark Murray on Mon, Mar 23, 1998 at 08:12:45AM %2B0200 References: <199803230612.IAA03716@greenpeace.grondar.za>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Murray:
|Randall Hopper wrote:
|> Thanks for the report Mark! Now its just a question of ioctl() or default
|> capture start behavior. Then I'll get the fxtv port chg PR in.
|
|I already have it in my local tree looking like a ports patch. Get the
|word from Satoshi, and I'll commit it in no time :-).
Mark Murray:
|Please may I add the following patch to graphics/fxtv. Without it, fxtv
|is useless.
If you don't mind doing 2 commits intead of just 1, sure. We still haven't
yet resolved who's going to clear that buffer and under what circumstances.
Amancio, what do you think about a BT848_CLEAR_ON_START ioctl(). When set
to False (the default), behavior is as before -- no clear. When True, the
portion of the buffer to be used for captured frames gets cleared before
the start is issued.
This would avoid having to make fxtv set-uid root or to request signals
1-29 times/sec just to use only the first one for bookkeeping.
Thanks,
Randall
Content-Description: patch-ab
|--- ../fxtv-0.46.ORIG/tvcapture.c Tue Oct 28 01:59:41 1997
|+++ tvcapture.c Sun Mar 22 16:43:45 1998
|@@ -1126,7 +1126,7 @@
| /* Just mmap the biggest buffer we'll need and be done with it. */
| /* (Buffer used for non-directvideo captures) */
| c->drv_buf = (TV_UINT8 *) mmap( (caddr_t)0, MAX_MMAP_BUF_SIZE,
|- PROT_READ|PROT_WRITE, 0, c->fd, (off_t)0 );
|+ PROT_READ, MAP_SHARED, c->fd, (off_t)0 );
| if ( c->drv_buf == (TV_UINT8 *) -1 ) {
| fprintf( stderr, "mmap of driver buffer failed: %s\n",
| strerror(errno) );
|@@ -1537,9 +1537,9 @@
| video.ramsize = 0;
|
| /* If TDEC is on, may be a while before old trash gets written on */
|- if ( c->fps != c->fps_max )
|+/* if ( c->fps != c->fps_max )
| memset( c->drv_buf, '\0',
|- g.w * g.h * c->pix_geom_list[ c->pix_geom_idx ].Bpp );
|+ g.w * g.h * c->pix_geom_list[ c->pix_geom_idx ].Bpp ); */
| }
| memcpy( &pix_geom, &c->pix_geom_list[ c->pix_geom_idx ],
| sizeof( pix_geom ) );
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980323061637.00745>