Date: Thu, 22 Aug 2013 22:47:30 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: src-committers@FreeBSD.org, svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-stable-9@FreeBSD.org, "David E. O'Brien" <obrien@FreeBSD.org>, Bruce Evans <brde@optusnet.com.au> Subject: Re: svn commit: r254626 - stable/9/usr.bin/yacc Message-ID: <20130822224100.X2060@besplex.bde.org> In-Reply-To: <864naios6h.fsf@nine.des.no> References: <201308212257.r7LMvUmY053608@svn.freebsd.org> <8638q2i1oo.fsf@nine.des.no> <86y57ugn00.fsf@nine.des.no> <20130822213005.H1824@besplex.bde.org> <864naios6h.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-2098027519-1377175650=:2060 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Thu, 22 Aug 2013, [utf-8] Dag-Erling Sm=C3=B8rgrav wrote: > Bruce Evans <brde@optusnet.com.au> writes: >> Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: >>> Oh, it's actually our own fault for including -Wredundant-decls in >>> CFLAGS. Is there a good reason to keep it? >> How else would you detect bogus declarations of library functions? Almo= st >> all -W flags are for detecting bugs that are mostly style bugs like this >> one. This one only becomes more than a style bug if: >> - the declaration becomes wrong >> - the header with the correct declaration becomes not included. > > OK, point taken. > ... > So what do you suggest? Revert David's change, or keep it (minus > extern) and remove the prototype from expr.y? > > I favor the latter option, since yyparse() is auto-generated and expr.y > can therefore (strictly speaking) not know what the correct prototype > looks like. Depends what the reason for merging the change is. Is it to cross-build old sources with a current yacc? Then changing the old sources is not so good. It makes them not-old, and missing the declaration going the other way with an old yacc. I now remember not really liking the change to expr.y in -current either for the same reason. It de-portabilizes the sources a little. Bruce --0-2098027519-1377175650=:2060--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130822224100.X2060>