Date: Mon, 20 Jan 2014 12:51:07 +1100 From: Lawrence Stewart <lstewart@freebsd.org> To: "Alexander V. Chernikov" <melifaro@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r260702 - head/sys/netinet Message-ID: <52DC810B.3080103@freebsd.org> In-Reply-To: <201401161150.s0GBo1c1069638@svn.freebsd.org> References: <201401161150.s0GBo1c1069638@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/16/14 22:50, Alexander V. Chernikov wrote: > Author: melifaro > Date: Thu Jan 16 11:50:00 2014 > New Revision: 260702 > URL: http://svnweb.freebsd.org/changeset/base/260702 > > Log: > Fix ipfw fwd for IPv4 traffic broken by r249894. > > Problem case: > Original lookup returns route with GW set, so gw points to > rte->rt_gateway. > After that we're changing dst and performing lookup another time. > Since fwd host is most probably directly reachable, resulting > rte does not contain rt_gateway, so gw is not set. Finally, we > end with packet transmitted to proper interface but wrong > link-layer address. > > Found by: lstewart > Discussed with: ae,lstewart > MFC after: 2 weeks > Sponsored by: Yandex LLC Thanks again for fixing this Alexander. Is the setfib fix going to hit the tree soon as well? Cheers, Lawrence
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52DC810B.3080103>