Date: Mon, 11 Feb 2002 05:44:12 -0800 (PST) From: Mike Makonnen <mike_makonnen@yahoo.com> To: FreeBSD-gnats-submit@freebsd.org Subject: bin/34831: [PATCH] send-pr -a doesn't work as advertised Message-ID: <200202111344.g1BDiCr32659@blackbox.pacbell.net>
index | next in thread | raw e-mail
>Number: 34831
>Category: bin
>Synopsis: [PATCH] send-pr -a doesn't work as advertised
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Feb 11 05:50:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: Mike Makonnen
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
>Description:
The -a switch to send-pr doesn't attach files to the 'Fix:' section if
the PR template is obtained from the environment variable $PR_FORM.
I've emailed the same patch to the GNATS developers.
>How-To-Repeat:
>Fix:
--- send-pr.diff begins here ---
Index: gnu/usr.bin/send-pr/send-pr.sh
===================================================================
RCS file: /home/ncvs/src/gnu/usr.bin/send-pr/send-pr.sh,v
retrieving revision 1.28
diff -u -r1.28 send-pr.sh
--- gnu/usr.bin/send-pr/send-pr.sh 10 Jan 2002 07:43:38 -0000 1.28
+++ gnu/usr.bin/send-pr/send-pr.sh 11 Feb 2002 13:10:26 -0000
@@ -295,6 +295,7 @@
if [ -n "$PR_FORM" -a -z "$PRINT_INTERN" ]; then
cp $PR_FORM $TEMP ||
( echo "$COMMAND: could not copy $PR_FORM" ; xs=1; exit )
+ [ -n "$ATTACHED_FILES" ] && echo "$ATTACHED_FILES" >> $TEMP
else
for file in $TEMP $REF ; do
cat > $file << '__EOF__'
--- send-pr.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202111344.g1BDiCr32659>