Date: Mon, 15 Sep 2008 05:54:14 +0300 From: Giorgos Keramidas <keramida@freebsd.org> To: Julian Elischer <julian@elischer.org> Cc: freebsd-current@freebsd.org, Robert Watson <rwatson@freebsd.org> Subject: Re: panic in rt_check_fib() Message-ID: <87fxo2qfu1.fsf@kobe.laptop> In-Reply-To: <48CD6266.4030008@elischer.org> (Julian Elischer's message of "Sun, 14 Sep 2008 12:13:42 -0700") References: <87prnjh80z.fsf@kobe.laptop> <alpine.BSF.1.10.0809131105280.55411@fledge.watson.org> <48CC14AD.4090708@elischer.org> <874p4ju8t3.fsf@kobe.laptop> <87zlmbstv1.fsf@kobe.laptop> <48CCAF23.1010605@elischer.org> <87tzcij383.fsf@kobe.laptop> <48CD6266.4030008@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= On Sun, 14 Sep 2008 12:13:42 -0700, Julian Elischer <julian@elischer.org> wrote: > Giorgos Keramidas wrote: >> Now an interesting question is: Is it `normal' that the USED rtentry >> objects keep going up at every interface restart and are (at least at >> first glance) not reclaimed as fast as they are acquired? > > does it happen with the old rt_check in the case where it doesn't crash? Hi Julian, Yes it happens with the old kernel too. I tried bringing the re0 interface up and down with a kernel compiled from a clean copy of base/head @ 182948. The rtentry's allocated seem to be going linearly up every time I restart the interface with the old, unpatched rt_check_fib() too. So if there is an rtentry leak, it exists in both the unpatched and the patched kernels. By going through the last rt_check_fib() you sent, I don't see an obvious place where the leak could occur in *this* function, so I will try to see if it's easier to find out where rtentry's are pulled from the related zone. Then by correlating these with the places where rtentry's are freed it may become more obvious why/when the USED objects get bumped. It may be just a missing RT_REMREF() elsewhere, but I can't tell for sure yet where/when this happens... I'll keep looking. In the meantime, the new rt_check_fib() has saved me from several semi-random panics a week, so I think I like it :-D --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkjNzmIACgkQ1g+UGjGGA7ZziQCbBWdjFqgHVjDGC650jh1Vk9J8 cZwAoL6pz63aXDTFyyOaL3ML4OEWq8eA =kfLK -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87fxo2qfu1.fsf>