Date: Mon, 01 Dec 2003 14:41:34 +0900 From: Takanori Watanabe <takawata@axe-inc.co.jp> To: Nate Lawson <nate@root.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ubsa.c Message-ID: <200312010541.OAA26027@axe-inc.co.jp> In-Reply-To: Your message of "Sun, 30 Nov 2003 20:19:19 PST." <20031130201755.K11560@root.org>
index | next in thread | previous in thread | raw e-mail
In message <20031130201755.K11560@root.org>, Nate Lawson wrote:
>On Sun, 30 Nov 2003, Shunsuke Akiyama wrote:
>> Modified files: (Branch: RELENG_4)
>> sys/dev/usb ubsa.c
>> Log:
>> MFC: revision 1.11
>>
>> Apply some fixups in the driver_t's.
>>
>> Revision Changes Path
>> 1.2.2.2 +1 -1 src/sys/dev/usb/ubsa.c
>>
>> --- src/sys/dev/usb/ubsa.c:1.2.2.1 Wed Dec 11 12:54:47 2002
>> +++ src/sys/dev/usb/ubsa.c Sun Nov 30 04:53:40 2003
>> @@ -237,7 +237,7 @@
>> };
>>
>> Static driver_t ubsa_driver = {
>> - "ubsa",
>> + "ucom",
>> ubsa_methods,
>> sizeof (struct ubsa_softc)
>> };
>>
>
>Are you sure this is the direction you want to go? The driver is called
>ubsa and has a man page called ubsa.4. Why make it inaccurate?
This is correct. Module name itself is ubsa, but this imprements
a kind of "ucom" interface and it shares ucom_devclass with other
ucom drivers. Driver name should be same in all devclass, or the unit number
management will got wrong.
Just like both host-pci bus bridge and pci-pci bus bridge has
same name "pcib".
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312010541.OAA26027>