Date: Sun, 19 Jul 2015 18:25:34 +0100 From: Mark R V Murray <markm@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285692 - head/sys/dev/random Message-ID: <E20EF52C-E70B-4459-A1C4-F84A166025CF@FreeBSD.org> In-Reply-To: <20150719170253.GO2404@kib.kiev.ua> References: <201507191605.t6JG5V3o038572@repo.freebsd.org> <20150719170253.GO2404@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 19 Jul 2015, at 18:02, Konstantin Belousov <kostikbel@gmail.com> =
wrote:
>=20
>> - printf("random: %s unblock wait\n", __func__);
>> + /* Only bother the console every 10 seconds or so */
>> + if (spamcount =3D=3D 0)
>> + printf("random: %s unblock wait\n", __func__);
>> + spamcount =3D (spamcount + 1)%100;
> Is ppsratecheck() not suitable for this due to use of > 1 sec period ?
Oooh! Very probably, thank you.
>> + error =3D tsleep(&random_alg_context, PCATCH, =
"randseed", hz/10);
>> + if ((error =3D=3D ERESTART | error =3D=3D EINTR))
> This is probably still valid, but I wonder if you mean || there.
> Then you could also remove extra ().
Oh, nuts. Got the wrong patch. Thank you.
> All your commits are breaking all style(9) rules. It would be nice to =
keep
> the style at least for the files where you added random harvesting and =
which
> are already mostly style compliant. E.g., what about wrapping lines =
at
> position somewhere between 72 and 80 ?
I=E2=80=99ll look, thanks!
M
--=20
Mark R V Murray
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E20EF52C-E70B-4459-A1C4-F84A166025CF>