Date: Wed, 6 Dec 2017 17:32:35 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... Message-ID: <5ad2e6ba-7209-0e20-bd69-f83ad3410b3a@FreeBSD.org> In-Reply-To: <19abac3b-8407-abd8-4fe9-c23d6bd7121f@selasky.org> References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <ea6c8eb5-f849-df2a-ab80-75d8ebc1edb8@FreeBSD.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> <cec48299-e075-fe51-1297-4eb10a4f7619@FreeBSD.org> <19abac3b-8407-abd8-4fe9-c23d6bd7121f@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Pt86p2xO0PdBqJaipKAdPll2364Pq05dA
Content-Type: multipart/mixed; boundary="LNJf8ON5Umkt2hKaTkjD6uffkLlipksKH";
protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org,
svn-src-all@freebsd.org, svn-src-head@freebsd.org
Message-ID: <5ad2e6ba-7209-0e20-bd69-f83ad3410b3a@FreeBSD.org>
Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale
share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping
sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/...
References: <201711241450.vAOEoSFW056744@repo.freebsd.org>
<ea6c8eb5-f849-df2a-ab80-75d8ebc1edb8@FreeBSD.org>
<0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org>
<cec48299-e075-fe51-1297-4eb10a4f7619@FreeBSD.org>
<19abac3b-8407-abd8-4fe9-c23d6bd7121f@selasky.org>
In-Reply-To: <19abac3b-8407-abd8-4fe9-c23d6bd7121f@selasky.org>
--LNJf8ON5Umkt2hKaTkjD6uffkLlipksKH
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 12/6/2017 4:53 PM, Hans Petter Selasky wrote:
> It would be nice if these utilities can be built standalone, outside th=
e
> buildworld target aswell. I've suggested adding an "all-install" varian=
t
> to make. Having to kick a buildworld to test-build contrib/ofed is quit=
e
> overkill, and that is some of reasoning behind the current Makefile lay=
out.
This is what buildworld+SUBDIR_OVERRIDE is for. The following patch
also mitigates the need to install libraries for build testing which
I'll commit tomorrow:
> commit 7cce144e821cbf2f4e70711928a8945137700b35 (HEAD -> master)
> Author: Bryan Drewery <bdrewery@FreeBSD.org>
> Date: Wed Dec 6 17:29:57 2017 -0800
>=20
> Look for libraries in OBJDIR when building outside of buildworld.
>=20
> This allows build testing more easily without establishing a sysroo=
t
> or installing the files.
>=20
> Sponsored by: Dell EMC
>=20
> diff --git share/mk/src.libnames.mk share/mk/src.libnames.mk
> index 2d172197ac53..fdd1a4866620 100644
> --- share/mk/src.libnames.mk
> +++ share/mk/src.libnames.mk
> @@ -359,7 +359,7 @@ LIB${_l:tu}?=3D ${LIBDESTDIR}${LIBDIR_BASE}/l=
ibprivate${_l}.a
> .endfor
>=20
> .for _l in ${_LIBRARIES}
> -.if ${_INTERNALLIBS:M${_l}}
> +.if ${_INTERNALLIBS:M${_l}} || !defined(SYSROOT)
> LDADD_${_l}_L+=3D -L${LIB${_l:tu}DIR}
> .endif
> DPADD_${_l}?=3D ${LIB${_l:tu}}
--=20
Regards,
Bryan Drewery
--LNJf8ON5Umkt2hKaTkjD6uffkLlipksKH--
--Pt86p2xO0PdBqJaipKAdPll2364Pq05dA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJaKJozAAoJEDXXcbtuRpfPHKwH/2qhORRAkFUbrzKO5BrnkHVP
7nA/N1QCKUyrFBD6zaAGSM12nkEHk642qFfoyK2ddFNZc9HgUt/7CzYNMuqbv3HI
E+Fg+hyOC6DbE+tSIy2a1Wq9AopBMJoi73TbMwbgrLt9VnPIiiDH/4Q1yFhuMHzl
Un4hp4LyyeGVN2sle2I9jHfHYt0+3G1HGZ0KyOVCcOcwOg8fksNspUiML72ItrEt
Gqq3nxJ/1dzjWN7GW2vBDqWBHn1WIklMXRedWuYd4QA67Br+ELItcAWVg3c3zsba
T9+gF9UuRZj/6CfZfpbQHaAw9xCjBf3DnNCl9dyuGWzxvnBGOzuSCXAacY2SFS4=
=fu/l
-----END PGP SIGNATURE-----
--Pt86p2xO0PdBqJaipKAdPll2364Pq05dA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5ad2e6ba-7209-0e20-bd69-f83ad3410b3a>