Date: Fri, 20 Dec 2013 10:01:15 -0800 From: Jack Vogel <jfvogel@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r259642 - head/sys/netinet Message-ID: <CAFOYbcnJczdxOTrj3vELs5h6%2BMGKaq5Ma3BQ3s535qF5sJUPJA@mail.gmail.com> In-Reply-To: <CAJ-VmokzW26%2BvLWr-RN5EFdBx1C6oS0WxONpGbD68BqXaVjzjg@mail.gmail.com> References: <201312200741.rBK7f3tL038123@svn.freebsd.org> <20131220084419.GK71033@FreeBSD.org> <CAJ-VmokzW26%2BvLWr-RN5EFdBx1C6oS0WxONpGbD68BqXaVjzjg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I agree with Gleb, ifdef 0 is silly, after all, that's why we have source history, its not like the offending code is gone forever :) So I guess its both of us muttering Gleb :) Jack On Fri, Dec 20, 2013 at 9:05 AM, Adrian Chadd <adrian@freebsd.org> wrote: > On 20 December 2013 00:44, Gleb Smirnoff <glebius@freebsd.org> wrote: > > > I didn't get to review of actual patch, but IMO it would be better > > just to remove the code, not ifdef 0 it. The code ifdefed has zero > > probability to be enabled in its current form. If we ever fix it, code > > would look very different. > > > > No reason to do followup commit, that was just me muttering. > > I figured it would be nicer in the short term to #if 0 it out whilst > some other discussions went on, just to make it really obvious in the > short term where the check was done. It's quite possible I'll > eventually just trim it entirely out. > > Thanks, > > > -a >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFOYbcnJczdxOTrj3vELs5h6%2BMGKaq5Ma3BQ3s535qF5sJUPJA>