Date: Sat, 6 Jan 2001 18:39:44 -0500 From: "Bosko Milekic" <bmilekic@technokratis.com> To: "Alfred Perlstein" <bright@wintelcom.net>, "Poul-Henning Kamp" <phk@critter.freebsd.dk> Cc: "Bosko Milekic" <bmilekic@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/musycc musycc.c Message-ID: <009201c07839$f29a2070$25cbca18@jehovah> References: <20010106132943.E15744@fw.wintelcom.net> <12666.978817510@critter> <20010106141257.F15744@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alfred wrote:
> * Poul-Henning Kamp <phk@critter.freebsd.dk> [010106 13:45] wrote:
> > In message <20010106132943.E15744@fw.wintelcom.net>, Alfred Perlstein
writes:
> > >* Bosko Milekic <bmilekic@FreeBSD.org> [010106 12:44] wrote:
> > >> bmilekic 2001/01/06 12:44:40 PST
> > >>
> > >> Modified files:
> > >> sys/dev/musycc musycc.c
> > >
> > >Grr, This isn't how it was supposed to be done. Would you mind terribly
> > >if I cleaned it up to what I intended it to be:
> >
> >
> >
> > >! if ((m->m_flags M_EXT) == 0) {
> >
> > How is this supposed to compile in either of the committed or proposed
> > versions ?
>
> How the hell should I know? :)
>
> not only that but we have one of my favorite bugs:
>
> while (csc->state != C_RUNNING)
> tsleep(&csc->state, PZERO + PCATCH, "crun", hz/10);
>
> should have no PCATCH, or somehow deal with the signal instead of
> looping forever.
>
> You're right, this file is pretty broken. :)
>
> --
> -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
> "I have the heart of a child; I keep it in a jar on my desk."
This was my stupid typo mistake. It's fixed now. Thanks for pointing it out
and sorry about that.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?009201c07839$f29a2070$25cbca18>