Date: Sat, 22 May 2010 15:06:52 +0300 From: keramida@freebsd.org (Giorgos Keramidas) To: Hajimu UMEMOTO <ume@freebsd.org> Cc: cvs-ports@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/editors/emacs Makefile Message-ID: <87ljbc16oz.fsf@kobe.laptop> In-Reply-To: <ygey6fcfdhl.wl%ume@mahoroba.org> (Hajimu UMEMOTO's message of "Sat, 22 May 2010 19:16:22 %2B0900") References: <201005211951.o4LJp46e084250@repoman.freebsd.org> <yge1vd4h5zr.wl%ume@mahoroba.org> <87bpc832m4.fsf@kobe.laptop> <20100522063751.GA87869@FreeBSD.org> <87y6fc1jxd.fsf@kobe.laptop> <ygezkzsfihm.wl%ume@mahoroba.org> <20100522084946.GA23161@FreeBSD.org> <ygey6fcfdhl.wl%ume@mahoroba.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
On Sat, 22 May 2010 19:16:22 +0900, Hajimu UMEMOTO <ume@FreeBSD.org> wrote:
> Hi,
>
>>>>>> On Sat, 22 May 2010 08:49:46 +0000
>>>>>> Alexey Dokuchaev <danfe@FreeBSD.org> said:
>
> danfe> Having `-nox11' suffixed ports nowadays (when we have OPTIONS framework
> danfe> stable and mature enough) is mostly archaic, and can in fact be
> danfe> confusing (like in this case). Previously, having the possibility to
> danfe> build non-graphic version of their editor without having to explicitly
> danfe> pass -DWITHOUT_X11 option was valued by some of us, but today preferred
> danfe> OPTIONS are cached between updates in /var/db/ports/, so it's really the
> danfe> same level of convenience without the need for slave port. Especially
> danfe> when it does not play well with master. Suffixed slaves are almost
> danfe> entirely limited to be useful only for non-OPTIONS ports these days.
>
> Yes, I think so, too. However, someone else want to have a slave port
> for an OPTIONS port, in general. So, it is worth having a framework
> for such needs, IMHO.
>
> danfe> One might argue that it's convenient to have -nox11 *package*, but in
> danfe> this case special care must be taken (lurk for BATCH and
> danfe> PACKAGE_BUILDING knobs in bpm). I would probably just went ahead and
> danfe> killed `editors/emacs-nox11' port and be done with it, if anyone asks.
>
> Though I myself always build from ports and don't use packages, having
> -nox11 package for emacs is good thing, IMHO.
> I'm not sure how useful emacs with DBUS without X11 is. Actually, I'm
> using emacs without both X11 and DBUS. How about disabling both, for
> now?
>
> Index: emacs-nox11/Makefile
> diff -u emacs-nox11/Makefile.orig emacs-nox11/Makefile
> --- emacs-nox11/Makefile.orig 2010-05-22 16:49:34.528548000 +0900
> +++ emacs-nox11/Makefile 2010-05-22 19:09:24.284033237 +0900
> @@ -5,14 +5,12 @@
> # $FreeBSD: ports/editors/emacs-nox11/Makefile,v 1.3 2010/05/21 19:49:46 keramida Exp $
> #
>
> +BATCH= yes
> +WITHOUT_DBUS= yes
> WITHOUT_X11= yes
> PKGNAMESUFFIX= -nox11
>
> MASTERDIR= ${.CURDIR}/../emacs
> LATEST_LINK= emacs-nox11
>
> -#.if ${OSVERSION} < 700000 && defined(WITH_DBUS)
> -#BROKEN= Does not currently build with dbus support
> -#.endif
> -
> .include "${MASTERDIR}/Makefile"
This looks nice. Let's pass it through the new maintainer of emacs*
ports and commit it if Ashish does not object.
--=-=-=
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
iEYEARECAAYFAkv3yOEACgkQ1g+UGjGGA7bDFACfXkbr8FHz7jesrSgy2tenVgFI
IukAn3uBUfQTq6HJXh9hT+uyXcgAw2NJ
=vIzb
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87ljbc16oz.fsf>