Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Mar 2003 18:14:11 +0300
From:      "Andrey A. Chernov" <ache@nagual.pp.ru>
To:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Cc:        das@FreeBSD.org
Subject:   Re: cvs commit: src/contrib/gdtoa gdtoaimp.h
Message-ID:  <20030326151410.GA20472@nagual.pp.ru>
In-Reply-To: <20030320054502.GA4308@HAL9000.homeunix.com>
References:  <200303192025.h2JKPjNr000550@repoman.freebsd.org> <20030320050712.GA48184@nagual.pp.ru> <20030320054502.GA4308@HAL9000.homeunix.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 19, 2003 at 21:45:02 -0800, David Schultz wrote:
> Do
> you see anything else I should bug the vendor about while I'm at
> it?  

With nowdays variant there is error in gethex.c:

CONST unsigned char *decpt, *s0, *s, *s1;
...
char decimalpoint = *localeconv()->decimal_point;
...
if (*s == decimalpoint) {
       ^^^ It fails, if decimal point is in upper half of code table, i.e.
       negative char.
       
Obvious fix:
unsigned char decimalpoint ...

-- 
Andrey A. Chernov
http://ache.pp.ru/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030326151410.GA20472>