Date: Thu, 7 Nov 2013 14:13:08 -0800 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Ian Lepore <ian@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Steve Kargl <kargl@FreeBSD.org> Subject: Re: svn commit: r257818 - in head/lib/msun: . src Message-ID: <20131107221308.GA61870@troutmask.apl.washington.edu> In-Reply-To: <1383860529.31172.233.camel@revolution.hippie.lan> References: <201311072120.rA7LKY1J061512@svn.freebsd.org> <1383860529.31172.233.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 07, 2013 at 02:42:09PM -0700, Ian Lepore wrote:
> On Thu, 2013-11-07 at 21:20 +0000, Steve Kargl wrote:
> > --- head/lib/msun/src/s_round.c Thu Nov 7 21:16:32 2013 (r257817)
> > +++ head/lib/msun/src/s_round.c Thu Nov 7 21:20:34 2013 (r257818)
> > @@ -52,3 +52,7 @@ round(double x)
> > return (-t);
> > }
> > }
> > +
> > +#if (LDBL_MANT_DIG == 53)
> > +__weak_reference(round, roundl);
> > +#endif
>
> I don't think that's a complete fix. I got a linker "undefined
> reference" error when testing your patch. I decided to make sure it
> wasn't a -DNO_CLEAN artifact and did a fresh build, and it just failed:
>
I just can't win today. I forgot "#include <float.h>" where
LDBL_MANT_DIG is defined. Can you try?
Index: src/s_round.c
===================================================================
--- src/s_round.c (revision 257818)
+++ src/s_round.c (working copy)
@@ -27,6 +27,8 @@
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
+#include <float.h>
+
#include "math.h"
#include "math_private.h"
--
Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131107221308.GA61870>