Date: Thu, 21 Feb 2002 09:31:18 +0000 From: Brian Somers <brian@freebsd-services.com> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: John Baldwin <jhb@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/bin/ps print.c Message-ID: <200202210931.g1L9VIuJ036795@hak.lan.Awfulhak.org> In-Reply-To: Message from Matthew Dillon <dillon@apollo.backplane.com> of "Wed, 20 Feb 2002 21:13:47 PST." <200202210513.g1L5DlS93001@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> :> It's a lot easier to just have ps axl show it, since the wchan > :> field is otherwise unused. Alternatively we could create a > :> synthesize field 'mwchan' which replaces the default 'wchan' for > :> ps output that does this combo. > : > :Sounds good to me. I actually did something like this for top. In top I had > :all mutex names start with a * to differentiate them from wait channel names, > :can you do a similar thing for mwchan? > : > :John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ > :"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > > Hmm. I don't think it's necessary, because the process state is > 'M' if it's blocked in a mutex, and I think I'd rather have the field > width. > > In anycase, here is the patch. I'll throw this into the tree tomorrow > if there are no objections. The only potential problem I can see is > that the header will now be 'MWCHAN' instead of 'WCHAN'. If that turns > out to be a problem we could make the header print as 'WCHAN'. I think this interface change is ok as long as it's not MFC'd. -- Brian <brian@freebsd-services.com> <brian@Awfulhak.org> http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org> Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202210931.g1L9VIuJ036795>