Date: Tue, 22 Aug 2023 16:59:40 -0700 From: Kevin Bowling <kevin.bowling@kev009.com> To: Kristof Provost <kp@freebsd.org> Cc: Sumit Saxena <sumit.saxena@broadcom.com>, Warner Losh <imp@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, src-committers@freebsd.org Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor Message-ID: <CAK7dMtA6FL%2BCzw9Z2TC2-N0cA=WshDBsEVam0__ift9VfFrq7Q@mail.gmail.com> In-Reply-To: <CAK7dMtCJhwpV96znB4if48FtWEy091ss-nmvMp5zoLUvtkAs%2BA@mail.gmail.com> References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> <CAK7dMtCJhwpV96znB4if48FtWEy091ss-nmvMp5zoLUvtkAs%2BA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 22, 2023 at 3:39=E2=80=AFPM Kevin Bowling <kevin.bowling@kev009= .com> wrote: > > > > On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost <kp@freebsd.org> wrote: >> >> On 27 Jun 2023, at 11:17, Kristof Provost wrote: >> >> On 4 Nov 2022, at 23:55, Warner Losh wrote: >> >> The branch main has been updated by imp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc786= 1020dc3a2a2d717 >> >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 >> Author: Sumit Saxena <sumit.saxena@broadcom.com> >> AuthorDate: 2022-11-04 22:24:32 +0000 >> Commit: Warner Losh <imp@FreeBSD.org> >> CommitDate: 2022-11-04 22:24:32 +0000 >> >> if_bnxt: Add support for VLAN on Thor >> >> Reviewed by: imp >> Differential Revision: https://reviews.freebsd.org/D36443 >> --- >> sys/dev/bnxt/bnxt.h | 3 +- >> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++-------------= ------ >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- >> sys/dev/bnxt/if_bnxt.c | 7 ++- >> 4 files changed, 74 insertions(+), 53 deletions(-) >> >> This commit appears to have broken vlan on these interfaces. >> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a= Dell T640, if that helps). >> >> A simple vlan creation on top of one: >> ifconfig vlan create >> ifconfig vlan0 vlan 201 vlandev bnxt0 >> >> Results in a loss of connectivity. The kernel logs this, which I assume = is related: >> >> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error.` >> >> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I ca= n create vlan interfaces on top of bnxt0 without losing connectivity. >> >> >> Should we revert this before 14.0? >> >> There=E2=80=99s also a report of what I think is the same issue in https= ://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133 >> >> There=E2=80=99s a proposed patch there, but it did not work for me. > > > In markj=E2=80=99s analysis he mentions the issue of the reinit. > > It sounds like there are multiple bugs in this driver but one quick band = aid may be to mark the driver as not needing re-init for VLAN modifications= .. that sounds unlikely and was probably an accident when the if reset func= tionality was added. You can check e1000 for that. Here's what I mean as a patch https://reviews.freebsd.org/D41558 > Note I don=E2=80=99t have this hw and haven=E2=80=99t audited the code so= this could be noise but it=E2=80=99s an easy thing to check. > >> Best regards, >> Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAK7dMtA6FL%2BCzw9Z2TC2-N0cA=WshDBsEVam0__ift9VfFrq7Q>