Date: Wed, 09 May 2018 12:07:34 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: John Baldwin <jhb@freebsd.org> Cc: Cy Schubert <cy@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333393 - head/sys/contrib/ipfilter/netinet Message-ID: <201805091907.w49J7Y0L003669@slippy.cwsent.com> In-Reply-To: Message from John Baldwin <jhb@freebsd.org> of "Wed, 09 May 2018 07:58:14 -0700." <4065288.o9QKfFzp22@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <4065288.o9QKfFzp22@ralph.baldwin.cx>, John Baldwin writes: > On Wednesday, May 09, 2018 02:07:09 AM Cy Schubert wrote: > > Author: cy > > Date: Wed May 9 02:07:09 2018 > > New Revision: 333393 > > URL: https://svnweb.freebsd.org/changeset/base/333393 > > > > Log: > > Document intentional fallthrough. (CID 976535) > > > > MFC after: 1 week > > > > Modified: > > head/sys/contrib/ipfilter/netinet/fil.c > > > > Modified: head/sys/contrib/ipfilter/netinet/fil.c > > =========================================================================== > === > > --- head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:02:58 2018 > (r333392) > > +++ head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:07:09 2018 > (r333393) > > @@ -1299,6 +1299,7 @@ ipf_pr_icmp(fin) > > } > > } > > #endif > > + /* fallthrough is intentional */ > > case ICMP_SOURCEQUENCH : > > case ICMP_REDIRECT : > > case ICMP_TIMXCEED : > > Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there are > three other instances of that style in ipfilter already (and none others > using this comment style). Thanks John. It's been fixed in r333393. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805091907.w49J7Y0L003669>