Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Aug 2017 10:20:37 +0300
From:      Andriy Gapon <avg@FreeBSD.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org
Subject:   Re: svn commit: r322601 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys
Message-ID:  <d19c50fa-fef2-30ee-ec2e-b6875053251e@FreeBSD.org>
In-Reply-To: <1870652.QF6rqaG5fn@ralph.baldwin.cx>
References:  <201708162340.v7GNeWrL098164@repo.freebsd.org> <4786e0df-cbbd-d0fe-2e45-682b9fe24652@FreeBSD.org> <1870652.QF6rqaG5fn@ralph.baldwin.cx>

next in thread | previous in thread | raw e-mail | index | archive | help
On 17/08/2017 20:07, John Baldwin wrote:
> On Thursday, August 17, 2017 10:42:51 AM Andriy Gapon wrote:
>> On 17/08/2017 02:40, John Baldwin wrote:
>>> Author: jhb
>>> Date: Wed Aug 16 23:40:32 2017
>>> New Revision: 322601
>>> URL: https://svnweb.freebsd.org/changeset/base/322601
>>>
>>> Log:
>>>   Mark ZFS ABD inline functions static.
>>>   
>>>   When built with -fno-inline-functions zfs.ko contains undefined references
>>>   to these functions if they are only marked inline.
>>>   
>>>   Reviewed by:	avg (earlier version)
>>
>> I think that you rushed a little bit on this one:
>> https://github.com/openzfs/openzfs/pull/444
>>
>> But no big deal, it will be easy to merge once the upstream wakes up :-)
> 
> Oof, I thought you had previously ok'd to commit this?  (I just hadn't gotten
> around to it.)  My apologies for misunderstanding.

I think I did.  It's good to have a fix sooner rather than later even if
it's not a final version.  Thanks!


-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d19c50fa-fef2-30ee-ec2e-b6875053251e>