Date: Thu, 17 Sep 2015 09:53:58 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r287892 - head/sys/dev/usb/wlan Message-ID: <55FA7196.40004@selasky.org> In-Reply-To: <CAJ-Vmo=P%2BzsOnM9uvzgcTjUB6TvONU5zLaOMCXMmrHZ2jOrJNQ@mail.gmail.com> References: <201509170301.t8H31KdP042687@repo.freebsd.org> <55FA6C62.6010705@selasky.org> <55FA6EA2.8050809@selasky.org> <CAJ-Vmo=P%2BzsOnM9uvzgcTjUB6TvONU5zLaOMCXMmrHZ2jOrJNQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Adrian, On 09/17/15 09:43, Adrian Chadd wrote: > .. I'm likely going to do exactly that as part of "making" if_rsu do > 11n and behave correctly. Right now it does neither. Thank you for helping out with the USB WLAN drivers. Yes, USB requests sleep and don't spin until they're done. > > But this is a pretty big design pattern flaw; all of the wifi drivers > use the usb library like this and .. well, unless you look under the > hood, you don't really realise that serialiser lock is being dropped > for you... :( Right. If you need any help test, code or review, let me know. Not dropping the mutex inside USB sleeping functions would force all USB drivers to use SX locks or lower in the locking hierherachy, for synchronization, which would not be so good. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55FA7196.40004>