Date: Thu, 07 Nov 2013 15:37:15 -0700 From: Ian Lepore <ian@FreeBSD.org> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Steve Kargl <kargl@FreeBSD.org> Subject: Re: svn commit: r257818 - in head/lib/msun: . src Message-ID: <1383863835.31172.235.camel@revolution.hippie.lan> In-Reply-To: <20131107221308.GA61870@troutmask.apl.washington.edu> References: <201311072120.rA7LKY1J061512@svn.freebsd.org> <1383860529.31172.233.camel@revolution.hippie.lan> <20131107221308.GA61870@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2013-11-07 at 14:13 -0800, Steve Kargl wrote:
> On Thu, Nov 07, 2013 at 02:42:09PM -0700, Ian Lepore wrote:
> > On Thu, 2013-11-07 at 21:20 +0000, Steve Kargl wrote:
> > > --- head/lib/msun/src/s_round.c Thu Nov 7 21:16:32 2013 (r257817)
> > > +++ head/lib/msun/src/s_round.c Thu Nov 7 21:20:34 2013 (r257818)
> > > @@ -52,3 +52,7 @@ round(double x)
> > > return (-t);
> > > }
> > > }
> > > +
> > > +#if (LDBL_MANT_DIG == 53)
> > > +__weak_reference(round, roundl);
> > > +#endif
> >
> > I don't think that's a complete fix. I got a linker "undefined
> > reference" error when testing your patch. I decided to make sure it
> > wasn't a -DNO_CLEAN artifact and did a fresh build, and it just failed:
> >
>
> I just can't win today. I forgot "#include <float.h>" where
> LDBL_MANT_DIG is defined. Can you try?
>
> Index: src/s_round.c
> ===================================================================
> --- src/s_round.c (revision 257818)
> +++ src/s_round.c (working copy)
> @@ -27,6 +27,8 @@
> #include <sys/cdefs.h>
> __FBSDID("$FreeBSD$");
>
> +#include <float.h>
> +
> #include "math.h"
> #include "math_private.h"
>
That seems to have fixed things.
Don't feel bad, I've got more tries in on the aicasm build thing and I
still don't have it right. I supposedly learned my lesson about messing
with build stuff 20 years ago, but I guess I'm getting a refresher.
-- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1383863835.31172.235.camel>