Date: Sat, 21 Jun 2008 09:21:49 GMT From: Weongyo Jeong <weongyo@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 143872 for review Message-ID: <200806210921.m5L9Lnca006256@repoman.freebsd.org>
index | next in thread | raw e-mail
http://perforce.freebsd.org/chv.cgi?CH=143872 Change 143872 by weongyo@weongyo_ws on 2008/06/21 09:21:43 don't force short transfers if the xfer directions are to OUT. Sometimes allowing short transfers to OUT makes problems such as failing USB's firmware loading. Affected files ... .. //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#6 edit Differences ... ==== //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#6 (text+ko) ==== @@ -978,7 +978,6 @@ USBD_NO_TIMEOUT, usbd_xfereof); } else { /* TX (bulk OUT) */ - xfer->flags |= USBD_FORCE_SHORT_XFER; xfer->flags |= USBD_NO_COPY; usbd_setup_xfer(xfer, sc->ndisusb_ep[NDISUSB_ENDPT_BOUT], @@ -993,8 +992,6 @@ UE_GET_XFERTYPE(ep->bmAttributes), UE_GET_DIR(ep->bEndpointAddress))); - xfer->flags |= USBD_FORCE_SHORT_XFER; - usbd_setup_xfer(xfer, sc->ndisusb_ep[NDISUSB_ENDPT_IOUT], ip, xfer->buffer, xfer->length, xfer->flags, NDISUSB_INTR_TIMEOUT, usbd_xfereof);help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806210921.m5L9Lnca006256>