Date: Tue, 26 Apr 2005 19:57:49 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Sam Leffler <sam@errno.com> Cc: Jose M Rodriguez <josemi@freebsd.jazztel.es> Subject: Re: rigth crc32 implementation Message-ID: <05b71132f579685de0459a3b762b26b5@xcllnt.net> In-Reply-To: <426EF6BD.6030207@errno.com> References: <200504261143.55195.josemi@redesjm.local> <20050426194208.GB7773@ns1.xcllnt.net> <426E9E1C.6020609@errno.com> <20050426221922.GD8621@ns1.xcllnt.net> <426EF6BD.6030207@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 26, 2005, at 7:19 PM, Sam Leffler wrote: > Marcel Moolenaar wrote: >> On Tue, Apr 26, 2005 at 01:01:32PM -0700, Sam Leffler wrote: >>> Note also there is CRC32 code of this sort in WEP and TKIP crypto >>> modules in the net80211 support. >> Sam, >> Given the seperation of crc32() into crc32_raw() and crc32(), with >> either crc32() only or otherwise both functions inlined, are there >> any obstacles preventing the 802.11 code from using the ones in >> src/sys/libkern? > > The wep+tkip usage is integral to the cipher so splitting it out would > likely slow them and, more importantly, would also require > revalidation (there are test vectors but they're pretty limited). > These modules are self-contained for various reasons so I'm leary of > switching. Understood. Seems like a good reason to leave it as-is. > I'll think about adding it under an #ifdef for those that want to > save 2Kbytes (the size of the crc tables). In my book, 2K isn't worth the trouble. Thanks for the info, -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?05b71132f579685de0459a3b762b26b5>