Date: Wed, 13 Feb 2019 06:42:38 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Enji Cooper <yaneurabeya@gmail.com> Cc: rgrimes@freebsd.org, Enji Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r344087 - in projects/import-googletest-1.8.1/lib/googletest: gmock/tests gtest/tests Message-ID: <201902131442.x1DEgcsa081703@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <E5B559C7-42BB-4ADC-A851-D4B3F2E80AD1@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 13, 2019, at 06:26, Rodney W. Grimes <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > >> Author: ngie > >> Date: Wed Feb 13 05:41:04 2019 > >> New Revision: 344087 > >> URL: https://svnweb.freebsd.org/changeset/base/344087 > >> > >> Log: > >> Compile the tests without -Werror for now > >> > >> I'm working on resolving the issue upstream on github > >> > >> Modified: > >> projects/import-googletest-1.8.1/lib/googletest/gmock/tests/Makefile > >> projects/import-googletest-1.8.1/lib/googletest/gtest/tests/Makefile > > > > Are we going to have to live with this project name of > > import-googletest-1.8.1 long term, or is this just a > > stepping stone? > > It?s a short lived project. I didn?t realize in the last year and a > half that branch names had formalized into something else, especially > since GUIDELINES.txt doesn?t state a naming convention. I do not know that they have formalized in any way. But as long as it is shorted lived it really does not matter much. Please do be careful when choosing a vendor/ directory name if that is where this is headed, 'import' and '1.8.1' are probably not wanted there at all, just googletest. > I could move the project to another name, > but that seems like a waste of a commit > and like it would make it more difficult to track the project history. I Agree. > -Enji -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902131442.x1DEgcsa081703>