Date: Tue, 20 Mar 2012 19:48:36 -0500 From: Mark Linimon <linimon@lonesome.com> To: John Baldwin <jhb@freebsd.org> Cc: Doug Barton <dougb@freebsd.org>, svn-src-all@freebsd.org, Dimitry Andric <dim@freebsd.org>, src-committers@freebsd.org, Bruce Evans <brde@optusnet.com.au>, svn-src-head@freebsd.org, Chris Rees <utisoft@gmail.com> Subject: Re: svn commit: r233052 - head/share/mk Message-ID: <20120321004836.GB30795@lonesome.com> In-Reply-To: <201203201728.21049.jhb@freebsd.org> References: <201203162319.q2GNJjx5039482@svn.freebsd.org> <201203201019.40486.jhb@freebsd.org> <CADLo839Ef3bu_14AdexOWapOacFLk3MM9HK-oNLmtA52Cc9C6w@mail.gmail.com> <201203201728.21049.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
The style in bsd.port.mk is not consistent. (I know, this is shocking
for something that's at r1.706.)
Here's what I recall seeing in it, that I found readable:
.if defined(USE_GL)
. if ${USE_GL:L} == "yes"
USE_GL= glu
. endif
. for _component in ${USE_GL}
. if !defined(_GL_${_component}_LIB_DEPENDS) && \
!defined(_GL_${_component}_RUN_DEPENDS)
IGNORE= uses unknown GL component
. else
LIB_DEPENDS+= ${_GL_${_component}_LIB_DEPENDS}
RUN_DEPENDS+= ${_GL_${_component}_RUN_DEPENDS}
. endif
. endfor
.endif
Various other bits of ports/Mk/*.mk use this same indentation; others
use two spaces, tabs, ...
Unfortunately the counter-argument of "let's just go fix it to have one
style" is all the patches against bsd.port.mk that would then no longer
apply.
Personally, I'd like to see us pick a "recommended way for new code",
whether it's one or two spaces, whatever. (8 spaces seems too much.)
mcl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120321004836.GB30795>